Skip to content

Set ValueType for auto with ternary#5304

Merged
chrchr-github merged 5 commits intocppcheck-opensource:mainfrom
chrchr-github:chr_autotern
Aug 18, 2023
Merged

Set ValueType for auto with ternary#5304
chrchr-github merged 5 commits intocppcheck-opensource:mainfrom
chrchr-github:chr_autotern

Conversation

@chrchr-github
Copy link
Copy Markdown
Collaborator

No description provided.

@chrchr-github
Copy link
Copy Markdown
Collaborator Author

Not sure if this is/was broken or correct:

static void misra_10_1_ternary(void)
{
    int a;
    uint8_t ui8;
    uint16_t ui16;
    int8_t i8;
    int16_t i16;

    a = ui16 << ui16; // 10.6
    a = ui16 << (get_bool(42) ? ui16 : ui16);
    a = ui16 << (get_bool(42) ? ui16 : (get_bool(34) ? ui16 : ui16)); // 10.4
    a = ui16 << (get_bool(42) ? (get_bool(34) ? ui16 : ui16) : ui16); // 10.4
    a = ui16 << (get_bool(42) ? i16 : (get_bool(34) ? ui16 : ui16)); // 10.1
    a = ui16 << (get_bool(42) ? (get_bool(34) ? ui16 : i16) : ui16); // 10.1 10.4
    a = ui16 << (get_bool(42) ? (get_bool(34) ? ui16 : ui16) : i16); // 10.1
}

@danmar
Copy link
Copy Markdown
Collaborator

danmar commented Aug 17, 2023

hmm when I read the misra pdf I think the output is improved. You can change the assertions:

static void misra_10_1_ternary(void)
{
    int a;
    uint8_t ui8;
    uint16_t ui16;
    int8_t i8;
    int16_t i16;

    a = ui16 << ui16; // 10.6
    a = ui16 << (get_bool(42) ? ui16 : ui16);
    a = ui16 << (get_bool(42) ? ui16 : (get_bool(34) ? ui16 : ui16));
    a = ui16 << (get_bool(42) ? (get_bool(34) ? ui16 : ui16) : ui16);
    a = ui16 << (get_bool(42) ? i16 : (get_bool(34) ? ui16 : ui16)); // 10.1 10.4
    a = ui16 << (get_bool(42) ? (get_bool(34) ? ui16 : i16) : ui16); // 10.1 10.4
    a = ui16 << (get_bool(42) ? (get_bool(34) ? ui16 : ui16) : i16); // 10.1 10.4
}

@chrchr-github
Copy link
Copy Markdown
Collaborator Author

hmm when I read the misra pdf I think the output is improved. You can change the assertions:

Thanks for looking into it, done.

@chrchr-github chrchr-github merged commit 7f22ef4 into cppcheck-opensource:main Aug 18, 2023
@chrchr-github chrchr-github deleted the chr_autotern branch August 18, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants